fix: closing lazygit when any neovim TermClose event fires
#226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Issue:** After starting lazygit, if you start an unrelated terminal in Neovim and then close it, the lazygit is also closed. This is because the `TermClose` event is currently triggered for all terminal buffers, not just the one running lazygit. I ran into this when using https://github.com/mikavilpas/yazi.nvim, but didn't notice it happens until now. **Solution:** Only close lazygit when the terminal buffer that lazygit is running in is closed.
|
See #225 (comment) to understand why the build fails |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
After starting lazygit, if you start an unrelated terminal in Neovim and then close it, the lazygit is also closed. This is because the
TermCloseevent is currently triggered for all terminal buffers, not just the one running lazygit.I ran into this when using https://github.com/mikavilpas/yazi.nvim, but didn't notice it happens until now.
Solution:
Only close lazygit when the terminal buffer that lazygit is running in is closed.